Comments on: Easy Javascript Validation with Javascript Lint For Rails Testing

By: Danny

Danny — Thu, 30 Jul 2009 14:07:07 +0000

I’m working on a very big project containing lots of javascript, so we started putting them into subdirectories. Based on what Maxim wrote I created the following. Note that I only care about semicolons (for minimizing), so I made the assertion a little different, not to include warnings about ParseInt and stuff… I’m also using jspec for test driven javascript development and we really want to ignore that directory…

def list(file_name)
Dir.new(“#{file_name}”).each do |file|
next if file.match(/^\.+/)
path = “#{file_name}/#{file}”
if FileTest.directory?(“#{path}”) && (path.scan(/spec/) == [])
list(“#{path}”)
else
if File.extname(path) == “.js”
puts path
describe “JSLint on #{path}” do
before {@it = %x[jsl -process #{path}]}
specify {@it.should include_text(’0 error(s)’)}
specify {@it.should_not include_text(‘lint warning: missing semicolon’)}
end
end
end
end
end

list(File.join(Rails.root, ‘public’, ‘javascripts/refactored’))

By: Jerry

Jerry — Fri, 10 Jul 2009 21:13:27 +0000

@Nick, IE certainly doesn’t think so…

By: Nick Grimshaw

Nick Grimshaw — Tue, 07 Jul 2009 13:18:52 +0000

…semicolons are optional in Javascript.

By: Maxim Kulkin

Maxim Kulkin — Wed, 01 Jul 2009 11:43:52 +0000

The more natural would be to have a separate test for each javascript file:

Dir[Rails.root+'/public/javascripts/*.js].each do |js|
test “javascript #{js} contains no syntax errors” do
assert_js_valid js
end
end

def assert_js_valid(js_path)
output = system(“jsl -process #{js_path}”)
valid = output.include?(’0 error(s)’)
assert valid, “Javascript #{js_path} contains following errors:\n#{output}”
end

By: Benjamin Quorning

Benjamin Quorning — Fri, 26 Jun 2009 18:42:24 +0000

Nice! I implemented it in RSpec. Not that pretty, but it works:

# spec/lib/javascript_spec.rb require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')

# Download jsl from http://www.javascriptlint.com and add the jsl to your PATH environment variable Dir[ File.join(Rails.root, 'public', 'javascripts', '*.js') ].each do |js_path| describe "JSLint on #{js_path}" do before { @it = %x[jsl -process #{js_path}] } specify { @it.should include_text('0 error(s)') } end end